Adding UMD support to help allow Typescript#203
Adding UMD support to help allow Typescript#203tonicblue wants to merge 6 commits intostrongloop:masterfrom tonicblue:umd-support
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
| debug('Customizing model %s', name); | ||
| code(model); | ||
| // If code is a default UMD module use it | ||
| } else if (code.hasOwnProperty('default')) { |
There was a problem hiding this comment.
Can we make this check more robust by also checking for the presence of code. __esModule?
There was a problem hiding this comment.
Makes perfect sense. Just committed an update.
Cheers
|
Hi @tonicblue, sorry for the delay. The patch LGTM. However, I am little bit worried about upgrading the test fixture files when TypeScript and/or ES6 changes how the code is generated and modules exported. I am proposing to add the original Thoughts? |
|
@davidcheung could you please take this patch over from me, since you are most familiar with the new refactored codebase now? |
|
Can one of the admins verify this patch? |
|
@raymondfeng @ritch this patch is enabling LoopBack users to write their apps in TypeScript. We may want to prioritize this feature in our backlog. |
7 participants
Relating to issue 202
Have included tests and added 2 lines to
.eslintignoreto ignore generated code.Signed-off-by: Matthew Wilkes matthew.wilkes@scvo.org.uk